Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-binlog: update the third-party dependency version in the kafkaRe… (#36043) #36777

Merged
merged 1 commit into from
Aug 1, 2022
Merged

tidb-binlog: update the third-party dependency version in the kafkaRe… (#36043) #36777

merged 1 commit into from
Aug 1, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 1, 2022 •
edited
Loading

cherry-pick #36043 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36777

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/36777:release-6.2-ad51561cb1b8

…ader example

What problem does this PR solve?

Issue Number: close #36042

Problem Summary:

The version of the third-party dependencies in the example are too old and we should update them.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 1, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 1, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 1, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/6.2-cherry-pick labels Aug 1, 2022
@ti-srebot
Copy link
Contributor Author

@s3nt3 please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

niubell
niubell approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2022
@niubell
Copy link
Contributor

niubell commented Aug 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@niubell: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f04b47e2eda40c3ec6375def61adecc9cfcd23f2

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f04b47e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@niubell
Copy link
Contributor

niubell commented Aug 1, 2022

/component binlog

@ti-chi-bot ti-chi-bot merged commit 4970ee8 into pingcap:release-6.2 Aug 1, 2022
@lichunzhu lichunzhu deleted the release-6.2-ad51561cb1b8 branch August 1, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@niubell niubell niubell approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/binlog release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.2-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @niubell @sre-bot @lance6716 @D3Hunter